On Thu, Jan 5, 2012 at 11:54 AM, Ramkumar Ramachandra <[email protected]> wrote: > Hi Yann, > > Yann Hodique wrote: >>>>>>> "Ramkumar" == Ramkumar Ramachandra <[email protected]> writes: >>> [1]: https://github.com/rafl/git-commit-mode >> >> Thanks, I'll give it a try. What about the metadata magit puts in the >> log-edit buffer before submitting ? Are there equivalent flags with >> git-commit-mode ? > > No. But I'm just deriving it from magit-log-edit-mode which puts in > those headers anyway, no? git-commit-mode just does some "syntax > highlighting". > > Tried it out? Do you like it?
Hey, yes I tried it, and somewhat liked it, but integration is still not great. In particular, syntax highlighting is broken when we make use of those magit metadata (like amending, or setting author) since git-commit-mode is very strict and expects first line to be the short description, second line to be empty, and so on. So that our additional text interferes. In the end, the buffer is still colorized, but with meaningless colors :) I can see 2 tracks to fix this: - either we can make git-commit-mode somehow skip our metadata altogether, if present - or we can get rid of our metadata block (I personally don't like it anyway), and for example put equivalent information in `header-line-format' where it would not "pollute" the actual commit text. Any idea ? Yann.
