>>>>> "Dale" == Dale Hagglund <[email protected]> writes:
> Hi everybody. Now that 1.1.1's out, I thought I'd ask about the fate of > some changes I posted late last year. > Around Christmas, I posted (both to the list and as a pull request) a small > set of changes I've accumulated since I've been using magit more seriously > for about a two months now. Unfortunately (at least from my perspective) I > haven't gotten any feedback, so I wondered if I inadvertently submitted the > changes in a way that doesn't work well for the list or the pull request > reviewers. Would, for example, it be better for people if I posted the > changes separately? (They are essentially independent.) In the > intervening weeks, I've found a few bugs / regressions in one of the > changesets, so I need to repost at least that anyway. > Any feedback would be much appreciated. Hi Dale, sorry for the lack of feedback. During the last weeks I've been trying to deal with the backlog we have, with mitigated success :) (not too bad on pull requests, not too good on issues). Anyway I must confess that having an identified issue in your request made it fall down the priority list :) Also, as you note (and this is a pretty general remark here), mixing various changes in a single pull request tends to delay treatment further, as the review is less "focused". I could (and do sometimes) cherry-pick changes, but when I'm doing so, I'd rather be sure the other ones are to be discarded. Otherwise I'm wasting everybody's time with useless history rewriting. Bottom line, shorter pull requests will get faster merge/feedback :) Anyhow, I plan having a look at your code in the coming days. Thanks, Yann. -- I must rule with eye and claw -- as the hawk among lesser birds. -- DUKE PAULUS ATREIDES, The Atreides Assertion
