On 24 Apr 2012, Rémi Vanicat uttered the following:

> Nick Alcock <[email protected]> writes:
>
>>                                  (if sign-off '("--signoff") '()))))))))
>>      ;; shouldn't we kill that buffer altogether?
>>      (erase-buffer)
>> -    (bury-buffer)
>> +    (let ((magit-buf magit-buffer))
>> +      (bury-buffer)
>> +      (set-buffer magit-buf))
>
> I would have probably use the with-current-buffer macro, but I'm not
> completely convince it would be useful. 

You could use it, but I can't find a formulation that's much more
complex than this, since we have to dig out the name of the edit buffer
to pass to `bury-buffer' if some other buffer is current at the time.

>>      (setq default-directory dir)
>>      (magit-log-edit-mode)
>> +    (make-local-variable 'magit-buffer)
>
> You should add a defvar for the magit-buffer variable, preferably with
> some useful help string. 

True. I keep forgetting that. :)

Will reroll and resend with a defvar.

-- 
NULL && (void)

Reply via email to