Hi all, I tried to add tag signing to magit and noticed, that git got a pty for the commit command, but not for the tag command, because the former calls magit-run-git-async-with-input, while the latter calls magit-run-git-with-input.
Both eventually call magit-run* and in the asynchronous, process-connection-type is set to magit-process-connection-type, while in the synchronous case it's set to nil, with the following comment: > Don't use a pty, because it would set icrnl > which would modify the input (issue #20). I actually failed to reproduce this mentioned issue. But it's a little dubious anyway, why one variant should force a pipe, while the other can have a pty... (Both get input from magit, the synchronous and asynchronous case) Since gpg seems to require a gpg, commit signing works, because "git commit" has a pty, while tag signing doesn't, because "git tag" doesn't have a pty. So, am I missing something here, or is this just messy as it looks like? Thanks for your input, HP -- --- You received this message because you are subscribed to the Google Groups "magit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
