This allows us to see at a glance which targets were forgotten.

"melpa" and "melpa-push" didn't have any corresponding targets,
so they were removed.

Signed-off-by: Pieter Praet <[email protected]>
---
 Makefile | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index af54dc0..5892dcc 100644
--- a/Makefile
+++ b/Makefile
@@ -43,10 +43,6 @@ VERSION=$(shell \
     (load-file \"magit-version.el\"))\
   (princ magit-version))")
 
-.PHONY: clean magit-version.el
-.PHONY: install-lisp install-docs install-script
-.PHONY: melpa melpa-push
-
 lisp:     $(ELCS) magit-version.el loaddefs
 all:      lisp docs
 
@@ -89,6 +85,8 @@ help:
 %.elc: %.el
        @$(BATCHC) $<
 
+# Not a phony target, but needs to run *every* time.
+.PHONY: magit-version.el
 magit-version.el:
        @printf "Generating magit-version.el\n"
        @printf ";;; magit-version.el --- the Magit version you are using\n\n" 
> $@
@@ -135,12 +133,14 @@ authors: AUTHORS
 install: install-lisp install-docs
 install-all: install install-script
 
+.PHONY: install-lisp
 install-lisp: lisp
        $(MKDIR) $(DESTDIR)$(lispdir)
        $(CP) $(ELS) $(ELCS) magit-version.el $(DESTDIR)$(lispdir)
        $(MKDIR) $(DESTDIR)$(LOADDEFS_DIR)
        $(CP) $(LOADDEFS_FILE) $(DESTDIR)$(LOADDEFS_DIR)/$(LOADDEFS_FILE)
 
+.PHONY: install-docs
 install-docs: docs
        $(MKDIR) $(DESTDIR)$(infodir)
        $(CP) magit.info $(DESTDIR)$(infodir)
@@ -148,6 +148,7 @@ install-docs: docs
        $(MKDIR) $(DESTDIR)$(docdir)
        $(CP) AUTHORS $(DESTDIR)$(docdir)
 
+.PHONY: install-script
 install-script: bin/magit
        $(MKDIR) $(DESTDIR)$(execdir)
        $(CPBIN) bin/magit $(DESTDIR)$(execdir)
@@ -157,6 +158,7 @@ test: $(ELCS)
        (put 'flet 'byte-obsolete-info nil))" \
        -l tests/magit-tests.el -f ert-run-tests-batch-and-exit
 
+.PHONY: clean
 clean:
        rm -f $(ELCS) $(LOADDEFS_FILE) magit-version.el magit.info
        rm -fr magit-$(VERSION) magit.spec *.tar.gz *.tar
-- 
1.7.11.1

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"magit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to