According to the commit message of baa09bb5, the author intended to
replace `nconc' with `append' in `magit-log-long', but the actual diff
does the inverse.

Based on the commit message and the author's comment @ bug 633 [1],
the intent was to replace `nconc' with `append' in `magit-log' (as
opposed to `magit-log-long').

So, partially revert commit baa09bb5 and make the intended change.

[1] https://github.com/magit/magit/issues/633#issuecomment-18315327

Signed-off-by: Pieter Praet <[email protected]>
---
 magit.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/magit.el b/magit.el
index bf72773..f100be1 100644
--- a/magit.el
+++ b/magit.el
@@ -5971,9 +5971,9 @@ (define-obsolete-function-alias 'magit-display-log-ranged 
'magit-log-ranged)
                         (magit-read-rev-range "Log" "HEAD")
                       "HEAD"))
          (topdir (magit-get-top-dir))
-         (args (nconc (list (magit-rev-range-to-git log-range))
-                      magit-custom-options
-                      extra-args)))
+         (args (append (list (magit-rev-range-to-git log-range))
+                       magit-custom-options
+                       extra-args)))
     (magit-buffer-switch magit-log-buffer-name)
     (magit-mode-init topdir 'magit-log-mode #'magit-refresh-log-buffer 
log-range
                      'oneline args)))
@@ -5990,8 +5990,8 @@ (define-obsolete-function-alias 'magit-display-log 
'magit-log)
                     (magit-read-rev-range "Long log" "HEAD")
                   "HEAD"))
          (topdir (magit-get-top-dir))
-         (args (nconc (list (magit-rev-range-to-git range))
-                      magit-custom-options)))
+         (args (append (list (magit-rev-range-to-git range))
+                       magit-custom-options)))
     (magit-buffer-switch magit-log-buffer-name)
     (magit-mode-init topdir 'magit-log-mode #'magit-refresh-log-buffer range
                      'long args)))
-- 
1.7.11.1

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"magit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to