> Any chance mo-git-blame could actually replace the current blame mode to > encourage contributions?
No chance. But we can take inspirations from it (and tig, git-blame.el, vc-annotate.el, and others) to implement *alternative* visulization methods. I don't think any of the various approaches are objectively better than the others. In some case one works better and in other cases another. It makes a difference whether the average chunk is larger than 1-2 lines or not and how wide windows usually are, just to mention two factors. And since magit-blame.el is well integrated with the rest of Magit, while mo-git-blame.el is not, it does not make any sense to replace the former with the latter. > I've promised myself to modify mo-git-blame to colorize the commits > properly, but I didn't get to it yet in months. Likewise I have intended to improve blaming for a long time. But it's not a priority because the current implementation works, while other equally important features are missing completely. > I hope somebody could step in. So yeah, it's on my TODO list, but I don't know when I'll get to it. If someone else wants to take a shot at this then I welcome that. Any implementation should clearly separate (1) calling git and parsing, (2) visualization, and (3) integration into the rest of Magit. Ideally the parsing would be improved a bit before even beginning to work on the visualization. Any implementation of the visual part should take into account that it is only intended to be one among many. Also it should be possible to switch the style without having to call git again, which means that abstractions have to be added which currently are missing. Best regards, Jonas -- You received this message because you are subscribed to the Google Groups "magit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
