I finally found the issue with coloring in magit modes. It looks like
font-lock mode resets all the faces after magit sets them. The following
seem to fix the problem but I’m not sure if this is something that should
be fixed in magit or in my emacs setup:
(add-hook 'magit-mode-hook '(lambda ()
(font-lock-mode 0))
Thoughts ?
On Tue, May 3, 2016 at 6:16 PM John Shahid <[email protected]> wrote:
this makes me think that my problem isn't related to the theme but
> something else, eg. a missing setting in magit
>
> On Tue, May 3, 2016 at 6:15 PM John Shahid <[email protected]> wrote:
>
>> Thanks Jonas for your suggestion. I tried the theme you pointed me to. I
>> like the colors on that one over the one I'm using. That said, it doesn't
>> seem to be working with `magit`. The diff is still displayed without any
>> color. any thoughts ?
>>
>>
>> On Tue, May 3, 2016 at 7:51 AM Jonas Bernoulli <[email protected]> wrote:
>>
>>> Also there is an alternative (and I believe more popular) solarized
>>> implementation: https://github.com/bbatsov/solarized-emacs. I use
>>> the light variant of that (and have contributed to it). Except for
>>> the lack of colors in popups I like it. In my fork you can find a
>>> commit which makes the popups more popular.
>>>
>>> John Shahid <[email protected]> writes:
>>>
>>> > Thanks for the pointer I'll check it out.
>>> >
>>> > On Sat, Apr 30, 2016, 11:18 PM Noam Postavsky <[email protected]>
>>> wrote:
>>> >
>>> >> On Sat, Apr 30, 2016 at 1:34 PM, John Shahid <[email protected]>
>>> wrote:
>>> >> > Hi all,
>>> >> >
>>> >> > I just updated from a really old version of magit v1.4 to the latest
>>> >> version v2.6. I'm using the latest solarized-dark theme. *Note* I'm on
>>> >> latest git sha for magit-mode, color-theme-solarized, and all magit's
>>> >> dependencies.
>>> >> >
>>> >> > After the update all the coloring that used to make it easy to read
>>> the
>>> >> diff (red for deletion, green for addition) is now gone. The diffs
>>> have no
>>> >> highlighting whatsoever.
>>> >>
>>> >> Maybe it's a color-theme-solarized problem? cf
>>> >> https://github.com/sellout/emacs-color-theme-solarized/pull/127
>>> >>
>>>
>>>
--
You received this message because you are subscribed to the Google Groups
"magit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
