Hi Piers,

Since you're just adding a new optional field, I don't see a reason for
not merging this in. It shouldn't affect anybody and can be readily
ignored by anybody who doesn't need it.

I've got two minor comments on the patch itself:

1- You don't really have to update the langpack in the example since the
list that's given there is a list of common/required fields, not a list
of all fields that are available.

2- Your change in lib/user.php has a superfluous line that's commented
out.

Cheers,
Francois

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/735909

Title:
  Feature: add remote user to CSV upload

Status in Mahara ePortfolio:
  New

Bug description:
  I'd like to add remoteuser as an upload field to the 'Add Users by
  CSV' function.  As part of this, I would also like to be able to set
  the remoteuser regardless of whether the auth type selected is
  'internal' or not.  I have attached a patch for this, and would
  appreciate some discussion around the proposal, and if there are any
  problems anyone can see with this.

  For the curious, the reason for wanting to have the remoteuser on
  internal auth types is so that eventually I could enable SAML users to
  have dual login (manual password, and SAML).

  Cheers,
  Piers Harding.

_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to     : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to