Reviewed: https://reviews.mahara.org/2760 Committed: http://gitorious.org/mahara/mahara/commit/887d5deb3cde9fb5b19a1cf4acc1f1df689b0f7d Submitter: Robert Lyon ([email protected]) Branch: master
commit 887d5deb3cde9fb5b19a1cf4acc1f1df689b0f7d Author: Robert Lyon <[email protected]> Date: Mon Dec 2 13:53:18 2013 +1300 Removing duplicate feed url rows (bug #1239461) Older sites can end up with duplicate rows in the blocktype_externalfeed_data for the same url. This causes problems if the site is using latest mahara as it stops one being able to add /edit a feed if there are duplicate rows for that feed's url. Change-Id: I47ee3952dbe75b5643adf55105a9219a3e3e8cd9 Signed-off-by: Robert Lyon <[email protected]> Signed-off-by: Aaron Wells <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1239461 Title: External feed has duplicate rows causing problems Status in Mahara ePortfolio: In Progress Bug description: Older sites can end up with multiple rows in the blocktype_externalfeed_data due to an earlier (now fixed) problem This causes problem when one tries to add a new rss feed block to a page if there is more than one row in the db of the same feed url. [WAR] bc (lib/errors.php:752) get_record_sql found more than one row. If you meant to retrieve more than one record, use get_records_*, otherwise check your code or database for inconsistencies Call stack (most recent first): log_message("get_record_sql found more than one row. If you mea...", 8, true, true) at /var/www/myportfolio-school2-testing-mahara/releases/20131010191940/lib/errors.php:109 log_warn("get_record_sql found more than one row. If you mea...") at /var/www/myportfolio-school2-testing-mahara/releases/20131010191940/lib/errors.php:752 SQLException->__construct("get_record_sql found more than one row. If you mea...") at /var/www/myportfolio-school2-testing-mahara/releases/20131010191940/lib/dml.php:347 get_record_sql("SELECT * FROM "blocktype_externalfeed_data" WHERE ...", array(size 3)) at /var/www/myportfolio-school2-testing-mahara/releases/20131010191940/lib/dml.php:365 get_record_select("blocktype_externalfeed_data", ""url" = ? AND "authuser" = ? AND "authpassword" ...", array(size 3)) at /var/www/myportfolio-school2-testing-mahara/releases/20131010191940/lib/dml.php:1143 ensure_record_exists("blocktype_externalfeed_data", array(size 3), object(stdClass), "id", true) at /var/www/myportfolio-school2-testing-mahara/releases/20131010191940/blocktype/externalfeed/lib.php:274 PluginBlocktypeExternalfeed::instance_config_save(array(size 9), object(BlockInstance)) at Unknown:0 To sort this out we are going to need a script in the the lib/db/upgrade.php to handle the clearing out of the duplicate rows and making sure the block instance configdata now points to the 1 row left in the db. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1239461/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
