The attached patch deals with the issue as reported. That said, turning back on the HTML editor, I've noted that it suffers from the same problem but for an entirely different reason. Given
================ <p>this is a reply</p> <p>this is a second line of a reply</p> ================ html2text returns ================ this is a reply this is a second line of a reply ================ So then, should this bug have its scope extended? ** Patch added: "Patch for 1271420" https://bugs.launchpad.net/mahara/1.10/+bug/1271420/+attachment/4145103/+files/1271420.patch -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271420 Title: Duplicate newlines in forum post notifications if you turn off the HTML editor Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: In Progress Status in Mahara 1.9 series: Confirmed Bug description: To replicate: 1. Go to your user account settings and turn the HTML editor off 2. Set the forum post delay to 0 minutes (to make testing quicker) 3. Make a forum post that runs across multiple newlines. 4. Look in your Inbox, and look at the email you receive Expected result: You should see one newline in the message for each newline in the original post Actual result: You'll see two newlines in the message for each one in the original post. This does not seem to happen when the HTML editor (TinyMCE) is active. Possibly TinyMCE strips out the newlines from the text before saving it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271420/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
