Reviewed: https://reviews.mahara.org/3476 Committed: http://gitorious.org/mahara/mahara/commit/c418557b689858a97834fcbf322b59c5dbb9a411 Submitter: Aaron Wells ([email protected]) Branch: 1.7_STABLE
commit c418557b689858a97834fcbf322b59c5dbb9a411 Author: Aaron Wells <[email protected]> Date: Tue Jan 14 12:35:48 2014 +1300 Silence most E_STRICT errors Bug 1268746: In PHP 5.4 E_ALL changed to include E_STRICT, causing Mahara to throw a lot of strict standards errors. This should silence most of them. HOWEVER, because most strict standards happen at compile-time, this will have no effect on strict standards errors caused in the files that have already been loaded by the time we call error_reporting() and set_error_handler(), which includes: - The file invoked directly by the URL - init.php - errors.php - config.php - config-defaults.php Change-Id: I7a7fdf7facb1f30e186a0e8a27f1c3b7473200da -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1268746 Title: Squelch PHP 5.4+ strict standards errors Status in Mahara ePortfolio: Fix Released Status in Mahara 1.7 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Bug description: Mahara sets its error reporting to E_ALL (in error.php). Prior to PHP 5.4, E_ALL, despite the name, did not include E_STRICT. Starting with PHP 5.4, it does include E_STRICT. Since Mahara has been running all this time with E_STRICT messages silenced, there are a lot of E_STRICT violations in the codebase, and on PHP 5.4+ servers, the logs are so full of them as to be useless. In the long term we should fix all the E_STRICT warnings, but for the short term we should just silence them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1268746/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
