I think it would avoid the most confusion if we prevent users from selecting a Draft journal entry in the first place. However, we do have to address the fact that a user can select a journal entry and then unpublish it, leaving a journal entry block with a draft journal entry selected.
So the full solution would be something like this: 1. In the artefact selector for the journal entry block, we prevent the user from selecting any Draft journal entries 2. AND if they select a Published journal entry, and then change that entry back to Draft later, we no longer display the journal entry's content in the block. 2a. Instead we show a placeholder that says something like "This journal entry has not yet been published." 2b. We should show that same placeholder to the journal owner themselves, as well. That'll make it crystal clear to them that the entry is not visible. Maybe we also give them a link to the journal entry's artefact page so that they can publish it there. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1387858 Title: Draft journal entries are visible to others Status in Mahara ePortfolio: Confirmed Status in Mahara 1.10 series: New Status in Mahara 1.8 series: New Status in Mahara 1.9 series: New Bug description: confirmed for master (15.04), 1.10, 1.9 and 1.8 When a user creates a journal entry as draft and puts that into a page, it is also visible to other users when they have access to the page. When the user puts the entire journal into a page (or tagged journal entries), the draft entry is not visible because it is in draft status. There are two possibilities as far as I can see right now: 1. Do not allow users to include journal entries that are in draft status into a page (and mention that in the block pop-up so they don't wonder why draft entries do not show up). 2. The block "Journal entry" needs to be changed so that draft entries are only visible to the author at most but not other users on the page. This should also include some visual indicator as we have in the journal itself for the draft. "Draft" could also be mentioned next to the title of the journal entry when selecting it in the block pop-up. I tend towards option 1 as that is cleaner and more in line with the behavior of the other blocks. We should then also mention on the other blocks that draft entries are not displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1387858/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
