Further to Aaron's comment... "2. We're actually trying to reduce the number of serialized data tables in the database because they've caused us headaches in the past due to not being very accessible by normal database SELECT & UPDATE operations. And the PHP serialize() method in particular poses a security risk. (See https://www.owasp.org/index.php/PHP_Object_Injection ). So, it'd be preferable to store data in normal DB tables & columns; or if that's not feasible, to store them as JSON rather than serialize()."
I've switched the code to using json encode. Since the diffs themselves aren't going to be the objects of selects or updates, I don't think there should be issues there. If we want to be able to find a change where we modified something, perhaps the revision record should have a field for a search description and/or tags? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1157543 Title: Record page editing history Status in Mahara ePortfolio: In Progress Bug description: I'd like to "dogfood" Mahara's developer documentation by moving it from Mediawiki to the Mahara platform itself, probably as group pages so it could still be edited by many people. One of the features that is lacking to make this feasible, though, is having an edit history. The wiki allows us to keep track of who made what edits, and to revert to older versions if necessary. So, I'd like to see Mahara gain the ability to keep track of a page's edit history. At a minimum it needs: 1. Who made changes, at what time 2. What the page looked like at each revision 3. Ability to revert the page to a previous version Also good would be: 4. Ability to "diff" versions and highlight what changed 5. Comments that go in the history log 6. "Publish" ability (including publishing at a later time/date) 7. Versioning file attachments, see also https://bugs.launchpad.net/mahara/+bug/548195 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1157543/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
