Reviewed: https://reviews.mahara.org/4136 Committed: http://gitorious.org/mahara/mahara/commit/1749c22376e3c8eee56904f4f96e1d287a868a13 Submitter: Robert Lyon ([email protected]) Branch: 1.10_STABLE
commit 1749c22376e3c8eee56904f4f96e1d287a868a13 Author: Son Nguyen <[email protected]> Date: Tue Nov 25 12:26:13 2014 +1300 Allow comments for selectors and properties in CSS. Bug 1384467 This allows all comments of top of CSS selectors and all inline comments attached to CSS properties Change-Id: I6d3cd5113ab097caa1736f7dfbdf39566cfb58d6 Signed-off-by: Son Nguyen <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1384467 Title: CSS is not stripping out bad css attributes anymore Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Bug description: If I add some custom CSS to a skin that has badly formed css it doesn't strip out the bad lines. eg: #footer { color: #deface; top:cat; width: 300px; odd:fellow; } It used to strip it down to leave the valid lines. eg: #footer { color: #deface; width: 300px; } This looks to have been broken with this patch https://reviews.mahara.org/#/c/3846/ Well not broken as such but the $preserve_css should be able to be set via either the site config or directly in the config.php file so that only sites that want to allow things like comments in the css can turn it on rather than it be on by default for the skins. It still strips out html tags - so that is good To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1384467/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
