** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1366622
Title:
width of gallery not set correctly
Status in Mahara ePortfolio:
Fix Released
Status in Mahara 1.10 series:
Fix Released
Status in Mahara 1.9 series:
Fix Released
Status in Mahara 15.04 series:
Fix Released
Bug description:
When creating an image gallery, a user can 'blank' out the 'Width'
field.
When the block is instantiated, the $configdata['width'] is set but
it's empty.
So, the $width is also empty.
i.e. $width = isset($configdata['width']) ? $configdata['width'] : 75;
I think the switch at the top should also check for '&&
$configdata['width'] > 0':
i.e.
switch ($style) {
case 0: // thumbnails
$template = 'thumbnails';
$width = isset($configdata['width']) && $configdata['width'] > 0 ?
$configdata['width'] : 75;
break;
case 1: // slideshow
$template = 'slideshow';
$width = isset($configdata['width']) && $configdata['width'] > 0 ?
$configdata['width'] : 400;
break;
case 2: // square thumbnails
//default:
$template = 'squarethumbs';
$width = isset($configdata['width']) && $configdata['width'] > 0 ?
$configdata['width'] : 75;
break;
}
Hope that makes sense.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1366622/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to : [email protected]
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
