Reviewed: https://reviews.mahara.org/4915 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/f49775838d62087aacde917d575000e780d7246f Submitter: Robert Lyon ([email protected]) Branch: 15.04_STABLE
commit f49775838d62087aacde917d575000e780d7246f Author: Robert Lyon <[email protected]> Date: Thu Jul 2 13:42:18 2015 +1200 Bug 1451331: Saving of text block with embedded media for old PHP The DOMDocument::saveHTML() function only gained the $node parameter in version 5.3.6 So we need a workaround for PHP 5.3.3 Change-Id: I1033c0411f25cd41a4ec83cd2258fc518927e3ab Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit cbe94a4c77ef9f1ad83449b379c1264a2bdd77bd) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1451331 Title: 15.04 image picker requires PHP 5.3.6+ Status in Mahara ePortfolio: Fix Committed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Fix Committed Bug description: As reported on the Mahara.org forums: https://mahara.org/interaction/forum/editpost.php?parent=29019 The awesome new TinyMCE Mahara image picker in Mahara 15.04, uses the $node argument of the DomDocument::saveHTML() method. This argument was only added in PHP 5.3.6. The problem is that, as of the last developer meeting, we purport to support Debian 6 (Squeeze) and later. But Squeeze only ships with PHP 5.3.3. So if we want to continue to claim to support Squeeze, we should probably make this work without the $node argument. Or, we should specify that we require at least PHP 5.3.6, and that if you're running it on Squeeze, you'll just have to manually upgrade your PHP version. Actually, in the README that shipped with 15.04 we put that we support Debian 5 (Lenny) which ships with PHP 5.2... so presumably it's already implied that you're manually upgrading your PHP version. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1451331/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
