Reviewed: https://reviews.mahara.org/5036 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/409036dbbe5ce15dd0c6f3819510be4818f15d71 Submitter: Robert Lyon ([email protected]) Branch: master
commit 409036dbbe5ce15dd0c6f3819510be4818f15d71 Author: Aaron Wells <[email protected]> Date: Mon Aug 3 16:57:23 2015 +1200 Better handling of array-based variables for transient login form (Bug 1480764) (behatnotneeded) Change-Id: I2d9a0a140e57c9b040fb3d19243a6bef8f7aa505 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1480764 Title: Transient login form can't handle array variables Status in Mahara: Fix Committed Bug description: You know how, when you're logged out of Mahara and you try to go to a page that isn't shared with the public, and you see a login form? We call that the "transient login page". It tries to be smart and remember the URL that you were trying to reach, and then forward you on there again after you log in. But the code that does just iterates over $_GET and runs htmlspecialchars() on each key & value. And this causes problems if the URL contains array values, i.e. http://www.example.com?foo[]=value1&foo[]=value2 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1480764/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
