Reviewed: https://reviews.mahara.org/5174 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/91cc873f0c42a237d5b9d6187b0526d194c01cc7 Submitter: Son Nguyen ([email protected]) Branch: master
commit 91cc873f0c42a237d5b9d6187b0526d194c01cc7 Author: Aaron Wells <[email protected]> Date: Wed Aug 26 13:41:49 2015 +1200 Whitelist the $user properties sent to email_user() (Bug 1488697) The old code passes every value from the form into email_user(), which has wound up causing problems because email_user() thinks $user->id refers to the user's ID, but in our case id refers to the usr_registration record. (There is no user created yet at this point) behatnotneeded: No infrastructure to test email yet Change-Id: I0d862c2d1b2fdba5d5a1dc0068ce594207ecace9 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1488697 Title: Users may not receive the registration email after approval Status in Mahara: In Progress Status in Mahara 1.10 series: Confirmed Status in Mahara 1.9 series: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: In Progress Bug description: Version: master (15.10), 1.10, 15.04 Platform: any Browser: any When a registration is approved, an confirmed email will be sent to the user using the function email_user(). By mistake, the registration id is passed to the function as the user id in line #146, htdocs/admin/users/actionregistration.php We need to unset this value To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1488697/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
