Reviewed: https://reviews.mahara.org/5492 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/84082da3faf16c2bbe0a224f67dc12787090cb10 Submitter: Robert Lyon ([email protected]) Branch: 15.10_STABLE
commit 84082da3faf16c2bbe0a224f67dc12787090cb10 Author: Jono Mingard <[email protected]> Date: Mon Sep 28 18:06:41 2015 +1300 Fix element attributes when creating custom layout (Bug #1486817) Set up the label and radio button combination properly Behat step needs to access the custom rows by id as fields all have the same label Change-Id: Ica93cbb1a33facee6770076f32b5abe23e9a2b36 (cherry picked from commit dc632ff8c3b3d3d0a045eeed1fae799e284d9b33) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486817 Title: Incorrect label setup when creating custom layout Status in Mahara: Fix Committed Bug description: Steps to reproduce - "Edit layout" on any page - Open "Create custom layout", change some stuff and click "Create new layout" - Without refreshing the page, inspect the newly created radio button and its associated label The radio button ID and label 'for' attribute don't match, and the label contains the text "100" instead of an accurate representation of the layout. If you refresh the page the label and radio button will be set up properly, so this only happens when the option is added with JavaScript. Affects latest master To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486817/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
