Reviewed: https://reviews.mahara.org/5700 Committed: https://git.mahara.org/mahara/mahara/commit/8a03b3d0c43b02dc6de8d0b736dae2f29cbd2708 Submitter: Aaron Wells ([email protected]) Branch: 15.10_STABLE
commit 8a03b3d0c43b02dc6de8d0b736dae2f29cbd2708 Author: Aaron Wells <[email protected]> Date: Mon Nov 9 17:42:09 2015 +1300 Make Mnet return collection URLs in same format as view URLs (Bug 1514299) Change-Id: Ic8cb9115654106f669b544f5f8b060d443a0a9f0 behatnotneeded: Can't yet test MNet methods in Behat. (cherry picked from commit 905ea6f1af04ff6eafc2d0b86f69d83521951fbb) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514299 Title: MNet method "get_views_for_user()" returns full urls for collections when it should return partial Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: See also https://github.com/MaharaProject/moodle- assignsubmission_mahara/issues/15 When a student is picking a collection in the Mahara assignment submission plugin for Moodle, the URLs for collections (both the preview URL and the navigation URL) are incorrect. This is because the get_views_for_user() method on the Mahara side returns an absolute URL for the collection['url'] field, while it returns a relative-to- wwwroot URL for the view['url'] field. I'm tackling this by putting workaround code in the submission plugin, and by patching Mahara to return the same ['url'] values for views & collections. And then eventually (when there are no more of the old, bad Mahara instances around) we can drop the workaround code from the Moodle plugin. Although I guess hopefully by then we won't be using MNet for the plugin anymore, anyway. :) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514299/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
