Reviewed: https://reviews.mahara.org/5845 Committed: https://git.mahara.org/mahara/mahara/commit/eebc7f1a252072a0ba58b06d723830da959589d4 Submitter: Aaron Wells ([email protected]) Branch: 15.04_STABLE
commit eebc7f1a252072a0ba58b06d723830da959589d4 Author: Aaron Wells <[email protected]> Date: Thu Dec 10 17:59:34 2015 +1300 minaccept: Syntax-checker on changed files only (Bug 1524601) behatnotneeded: Not a change to Mahara's front end Change-Id: I379b2192c3518690ee1d39c0997b599d9dc91f7a (cherry picked from commit 9f357637d773c3a239f3ce7e9f9a1bd6bc92ee5b) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1524601 Title: Speed up minaccept by only linting changed files Status in Mahara: Fix Committed Status in Mahara 1.10 series: In Progress Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Bug description: "make push" takes a long time to finish on my computer. On my laptop at home, just one small change takes about 48 seconds to run through minaccept. I've found myself more frequently just doing "git push gerrit HEAD:refs/publish/master" rather than waiting for it to finish. So, I decided to see if I could speed things up. And it seems the biggest use of time in the minaccept is that it runs "php -l" on every PHP file in htdocs, not just the ones that have changed. Same for xmllint on all the XML files, but that's not as big of a problem because there aren't as many of them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1524601/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
