Public bug reported:
There's some very old code in the Mahara upgrader that looks at
$config->disablelogin in the lib/db/version.php file, to determine
whether user logins should be disabled during the upgrade.
I think the intent behind adding this, was to allow the version.php to
indicate whether the upgrade is a big enough change that users need to
be logged out during it. This makes a certain sense if used in
combination with strict discipline in testing and updating
$config->minupgradefrome.
However, in practice, we've had "disablelogin" set to true since 2008.
And given how many Mahara versions there are now, it's safer just to
force users to log out, as we have been doing for the past 7 years.
So I think it'd be best to remove this bit of code, since we never use
it.
** Affects: mahara
Importance: Low
Status: Confirmed
** Tags: refactoring
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1526076
Title:
Get rid of obsolete option "disablelogin" in lib/db/version.php
Status in Mahara:
Confirmed
Bug description:
There's some very old code in the Mahara upgrader that looks at
$config->disablelogin in the lib/db/version.php file, to determine
whether user logins should be disabled during the upgrade.
I think the intent behind adding this, was to allow the version.php to
indicate whether the upgrade is a big enough change that users need to
be logged out during it. This makes a certain sense if used in
combination with strict discipline in testing and updating
$config->minupgradefrome.
However, in practice, we've had "disablelogin" set to true since 2008.
And given how many Mahara versions there are now, it's safer just to
force users to log out, as we have been doing for the past 7 years.
So I think it'd be best to remove this bit of code, since we never use
it.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1526076/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to : [email protected]
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
