Reviewed: https://reviews.mahara.org/5849 Committed: https://git.mahara.org/mahara/mahara/commit/1404fe80dc104fba789383502bc2adcda8ac5dc5 Submitter: Robert Lyon ([email protected]) Branch: master
commit 1404fe80dc104fba789383502bc2adcda8ac5dc5 Author: Aaron Wells <[email protected]> Date: Tue Dec 15 12:36:17 2015 +1300 Rename $CFG->siteclosed to $CFG->siteclosedforupgrade Bug 1526101: This should help make it clearer what's going on in init.php and the related auth code, by making the distinction between $CFG->siteclosed and $CFG->siteclosedbyadmin clearer. behatnotneeded: Covered by existing tests Change-Id: I8bc728622ae965ce25b55ee4b55278771fc1eedc -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1526101 Title: Refactor $CFG->siteclosed to $CFG->siteclosedforupgrade Status in Mahara: Fix Committed Bug description: Every time I look at init.php I get confused about what the difference is between "siteclosed" and "siteclosedbyadmin" and the various $siteclosedforupgrade variables. Here's how it actually works: 1. $CFG->siteclosedbyadmin is the config that indicates whether the admin has used the "close site" button to put the site into maintenance mode 2. $CFG->siteclosed is set by Mahara itself, if it detects that there is a database upgrade ready to be deployed. It should *not* be manipulated by users, in normal circumstances. I think it would make things clearer for future developers, if we renamed "siteclosed" to "siteautoclosedforupgrade". This indicates why we're closing it (for upgrade), and that it was done automatically. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1526101/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
