Reviewed: https://reviews.mahara.org/6058 Committed: https://git.mahara.org/mahara/mahara/commit/4f400da4d07df72dec2192ae92581f71877ea1b6 Submitter: Robert Lyon ([email protected]) Branch: master
commit 4f400da4d07df72dec2192ae92581f71877ea1b6 Author: Jean-Philippe Gaudreau <[email protected]> Date: Fri Feb 12 15:44:16 2016 -0500 Bug 1514273: Increase to longtext col holding serialized data In MySQL, the default "text" column size is 65kB. Because this column can hold the serialized text from several other columns, it needs to be larger than that. Setting it to "big" generates a "longtext", which is 4GB. This change has no effect in Postgres. Postgres has only one text size (unlimited). The XMLDB generator is smart enough that it recognizes this and doesn't run any SQL in this case. behatnotneeded: Changes on database columns types only. Change-Id: I2b72e840676cb7345561ef81d51846509bc04049 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514273 Title: Increase to "longtext" all text columns that hold serialized user data Status in Mahara: Fix Committed Bug description: We've now had two bugs caused by serialized user data going into a text database column, and being truncated to 65KB by MySQL: Bug 1474659: import_entry_requests.entrycontent Bug 1513851: activity_queue.data We should try to get ahead of this issue by similarly increasing the size of any other columns in the database that typically store serialized user data. For instance, block_instance.configdata. If you created a text block that contains exactly 65KB of text, it would probably cause this same error, because, when serialized, it would tip to just over 65KB. I can't recall other serialized data columns off the top of my head, but I imagine there's a few. Additionally, if we have any other columns that store structured data with user content inside of it, we should expand those as well. (Are we storing any JSON-encoded values into the DB yet?). HTML is kind of an exception, because, while it will break if it's truncated, it won't generally cause a fatal error if we have broken HTML in the DB. Instead, htmlpurifier will filter it out when it gets displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514273/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
