Reviewed: https://reviews.mahara.org/5854 Committed: https://git.mahara.org/mahara/mahara/commit/03843792e20a46d9e6a2d6f493f64d03dc6d947c Submitter: Robert Lyon ([email protected]) Branch: master
commit 03843792e20a46d9e6a2d6f493f64d03dc6d947c Author: Aaron Wells <[email protected]> Date: Wed Dec 16 19:46:05 2015 +1300 Add "submitelement" attribute to Pieform button elements Bug 1526624 behatnotneeded: This one actually probably could use some behat tests. ;) But I'm curious to see if it'll pass automated testing. Change-Id: If1c199125d702750011777de1682acdc824dc8ca -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1526624 Title: Pieforms can't tell which "button" element submitted a form Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Bug description: With Mahara 15.10, we replaced a lot of the old <input type="submit"> tags with <button type="submit"> to provide for more flexible styling. However, no one realized that deep inside Pieform's creaky old internals, it expected your submit element to be flagged with "$element['submitelement'] = true". Without this, if there are multiple buttons in a pieform, all of their values show up in the submit method, instead of just the one that was pressed. This is the underlying cause of Bug 1526614 ("reject" button causes you to join a group). The accept & reject buttons were previously input tags, and had been changed to buttons. The submit handler function, thinking only one or the other could be pressed, only checked for the presence of the "accept" button. Without "submitelement" on it, the accept button's value (and the decline button's value) came through every time. In the old "submit" element, this flag is added automatically by the pieform_element_*_set_attributes() hook. I've added a similar hook to the button element that only adds it if it's a submit button (since we can also have non-submitting buttons, for Javascript). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1526624/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
