Reviewed: https://reviews.mahara.org/5974 Committed: https://git.mahara.org/mahara/mahara/commit/95ffbce0f44de68f4ae8141d27d917af8c3f6a96 Submitter: Robert Lyon ([email protected]) Branch: master
commit 95ffbce0f44de68f4ae8141d27d917af8c3f6a96 Author: Robert Lyon <[email protected]> Date: Wed Jan 27 17:12:56 2016 +1300 Bug 1557825: Remove view.numcolumns db column As this is confusing debugging issues with view layout as the view.numcolumns column is not actually used anymore for working out the layout, but it's still being populated when a page is made. behatnotneeded - existing tests will do Change-Id: If90dff066201e7356601b08c9b7150cab8a77f45 Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1557825 Title: Remove unused view.numcolumns database field Status in Mahara: Fix Committed Bug description: Spun off from Bug 1537861. Prior to Mahara 1.8, the view.numcolumns field indicated how many columns a view had, which was important because that's pretty much all the page layout we had in Mahara 1.7 and earlier. In Mahara 1.8 we moved to the more complicated "flexible layout" system, where a page can have multiple rows, and each row can have a different number of columns and column widths. With that in place, we stopped using the view.numcolumns field. However, the field stayed in the database for some reason, possibly just overlooked or possibly for backwards compatibility. While working on Bug 1537861, Robert suggested that we should remove this column, because at the moment it's vestigial and just makes things confusing for people looking at the database and/or the code. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1557825/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
