Reviewed: https://reviews.mahara.org/6164 Committed: https://git.mahara.org/mahara/mahara/commit/cfad522e53c796e6817f57778910edfa7daf32be Submitter: Robert Lyon ([email protected]) Branch: 15.04_STABLE
commit cfad522e53c796e6817f57778910edfa7daf32be Author: Aaron Wells <[email protected]> Date: Fri Nov 6 18:55:40 2015 +1300 Explicitly commit artefact to avoid buggy destructor (Bug 1513716) Since this blog post object wasn't committed after having its description updated, it causes the destructor to try to save the changes to the database, and that sometimes throws a fatal error if PHP garbage-collects the global $db variable before it calls this constructor. behatnotneeded: Covered by existing "edit_journal.feature" Change-Id: I5056ecce91b823b245cb5bd29f0676a35a6afd45 (cherry picked from commit 294fa9a4edc5580cdc7a1c3c0c021e2f4b562884) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513716 Title: Intermittent error "Call to a member function StartTrans() on a non- object" when saving a blog post in 15.04 Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: See https://mahara.org/interaction/forum/topic.php?id=7397 Also https://bugs.launchpad.net/mahara/+bug/1513710 The Embedded Image code ( https://reviews.mahara.org/#/c/5128/ ) adds a line to blog/post.php that does "set()" on an artefact without subsequently calling "commit()". This causes the (buggy) artefact destructor method to try to save the object to the database when the script ends, and that can cause an intermittent fatal error if $db got garbage collected before the artefact destructor was called. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513716/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
