Reviewed: https://reviews.mahara.org/6182 Committed: https://git.mahara.org/mahara/mahara/commit/a4134f74cee1e6097d5524705ed326033f5135f4 Submitter: Robert Lyon ([email protected]) Branch: master
commit a4134f74cee1e6097d5524705ed326033f5135f4 Author: Kristina D.C. Hoeppner <[email protected]> Date: Fri Mar 18 16:12:07 2016 +1300 Bug 1558885: Change the overriding start / end date lang string This is an interim fix only until the functionality can be corrected to not allow people to pick access dates outside of the overriding start / end dates. behatnotneeded: Just a lang string that doesn't exist in a test yet. Change-Id: Iff7841084a798e5e184a9842465ac947c62b000d -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1558885 Title: Lang string for overriding start/end date is confusing Status in Mahara: Fix Committed Bug description: This is an interim fix as it is an easy fix. A better fix involves a developer and is mentioned at bug #1558883. When a user has an overriding start / end date set which overrides any other access, the sentence reads (setting both start and end date in this example): Nobody else can see this page before 2 March 2016 or after 31 March 2016. The "else" is not clear because if you do set a start / end date for individual users, e.g. Nobody else can see this page before 2 March 2016 or after 31 March 2016. UserB 01/04/2016→15/04/2016 Then you'd expect that the "Nobody else" does not include UserB, but it does. The lang string should be changed to "Nobody can see ..." and leave out the "else". It's not a perfect fix, but I'd like to avoid adding a lengthy explanation as not everybody would have individual users set up. I find it clearer though than "Nobody else" as that indicates to me that it is "Nobody else but the other person listed". How to test: 1. Create two users. 2. Create a page in UserA's account and make it accessible to UserB (either with a start or end date or without. That doesn't matter. 3. Go into "Advanced options" and choose an overriding start / end date. 4. Save the settings. 5. With the patch applied, the first line should start "Nobody can see this...." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1558885/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
