Reviewed: https://reviews.mahara.org/5978 Committed: https://git.mahara.org/mahara/mahara/commit/4d6abc2b5a466f918ea6a86526d65f696ab05d52 Submitter: Robert Lyon ([email protected]) Branch: master
commit 4d6abc2b5a466f918ea6a86526d65f696ab05d52 Author: Robert Lyon <[email protected]> Date: Fri Jan 29 09:58:49 2016 +1300 Bug 1539262: Making constant SUBSECTIONHEADING To make this similar to PAGEHEADING / TITLE for consistency This allows the for it to display when an AccessDeniedException is thrown. Also fixing up where the PAGEHEADING / SUBSECTIONHEADING were set in the wrong order. behatnotneeded - existing tests should be fine Change-Id: Ife016639aa8f444e6d3f3183e3753cd9f8e9aae4 Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539262 Title: Sorting out TITLE / PAGEHEADING / SUBSECTIONHEADING for pages Status in Mahara: Fix Committed Bug description: Following on from Bug #1529731 I notice that there is a lot of duplication of code / non-consistent use of the TITLE / PAGEHEADING / SUBSECTIONHEADING for pages. There are many places where the TITLE - set as a defined value for a php file is exactly the same as PAGEHEADING which is passed into $smarty after the fact. It would be easier to allow the PAGEHEADING to be set as TITLE if their is no overriding PAGEHEADING set. I've also feel the SUBSECTIONHEADING should be set as a constant rather than a $subsectionheading variable to keep it consistent with the other ones. For the setting of the PAGEHEADING and SUBSECTIONHEADING constants the order they appear in the <h1> tag was not consistent. Normally the values are set as: SUBSECTIONHEADING = the particular instance title PAGEHEADING = the umbrella title For example, for a group's pages it is: SUBSECTIONHEADING = Pages PAGEHEADING = Group 1 (the name of the group) Which displays as: <h1>Pages | Group 1</h1> So I'll make a few patches to clean this up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539262/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
