Reviewed: https://reviews.mahara.org/6407 Committed: https://git.mahara.org/mahara/mahara/commit/40d2158daab8b5512a0bbadbd64fede4d4026d0a Submitter: Robert Lyon ([email protected]) Branch: 16.04_STABLE
commit 40d2158daab8b5512a0bbadbd64fede4d4026d0a Author: Darren Harkness <[email protected]> Date: Tue Apr 26 17:06:31 2016 +1200 Bug 1574716: Can't use empty() on a function return value in PHP 5.3 behatnotneeded - issue with older versions of php Change-Id: Ib732c593a1bbd37bf35cd747b9b57c992b8c1681 Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit 820860024e00862691169a32f9da729c373a5a05) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1574716 Title: Fatal error in lib/form/elements/ratings.php Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: When loading a portfolio in 16.04RC2, a white screen is encountered, and the following is written to the error log. This also occurred in 16.04RC1. [25-Apr-2016 09:26:36] PHP Fatal error: Can't use function return value in write context in /home/darren/public_html/m1604rc2/lib/form/elements/ratings.php on line 71 [25-Apr-2016 09:26:36] PHP Stack trace: [25-Apr-2016 09:26:36] PHP 1. {main}() /home/darren/public_html/m1604rc2/view/view.php:0 [25-Apr-2016 09:26:36] PHP 2. pieform() /home/darren/public_html/m1604rc2/view/view.php:221 [25-Apr-2016 09:26:36] PHP 3. Pieform::process() /home/darren/public_html/m1604rc2/lib/mahara.php:4493 [25-Apr-2016 09:26:36] PHP 4. Pieform->__construct() /home/darren/public_html/m1604rc2/lib/pieforms/pieform.php:161 [25-Apr-2016 09:26:36] PHP 5. Pieform->include_plugin() /home/darren/public_html/m1604rc2/lib/pieforms/pieform.php:406 This occurs on RHEL6, with PHP 5.3.3 [darren@swiftly m1604rc2]$ php -v PHP 5.3.3 (cli) (built: Jul 3 2015 03:10:33) Copyright (c) 1997-2010 The PHP Group Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies with Xdebug v2.1.4, Copyright (c) 2002-2012, by Derick Retinas This can be resolved by removing the !empty() on lines 48, 58, and 71 - see attached patch. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1574716/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
