Reviewed: https://reviews.mahara.org/6331 Committed: https://git.mahara.org/mahara/mahara/commit/cec21df83dd5966585e4a64dc2cd891a486695a9 Submitter: Robert Lyon ([email protected]) Branch: 15.10_STABLE
commit cec21df83dd5966585e4a64dc2cd891a486695a9 Author: Charlie <[email protected]> Date: Tue Apr 5 09:30:20 2016 +1200 Bug 1509129: Behat test for notification of public comment Change-Id: I2f6bea69724c660724bc7b44fd6f6530ee6c5d0c (cherry picked from commit 3f67778259b351b5986dbb426256756e73f2e935) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1509129 Title: Crash when posting a public comment that no one will be notified about Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Released Status in Mahara 16.10 series: Fix Committed Bug description: The code that sends out comment notifications tries to merge two arrays, representing the users who need to be notified because they "own" the page, and the users who have the page on their watchlist. If there are no "owner" users for a page, then this code fails because that variable holds a boolean false instead of an array. This only happens for public comments, because for private comments the watchlist is ignored, so there's no need to try to merge the arrays. To replicate: 1. Create a group 2. In the group's settings set "Feedback notifications" to "None" 3. Create a page in the group 4. Leave a public comment on the page Expected result: Your public comment should be posted on the page Actual result: The AJAX "processing" message comes up but never finishes, and the comment doesn't post To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1509129/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
