Reviewed: https://reviews.mahara.org/6508 Committed: https://git.mahara.org/mahara/mahara/commit/ff5b7d8c7802345ab16d1d4e1eb936ef418fda83 Submitter: Son Nguyen ([email protected]) Branch: 16.04_STABLE
commit ff5b7d8c7802345ab16d1d4e1eb936ef418fda83 Author: Aaron Wells <[email protected]> Date: Wed May 18 14:40:14 2016 +1200 Bug 1582967: Make "Delete Comment" form IDs unique Change-Id: I4a217eda8ae6ec9691541cc38c3efd3538aa2c0b behatnotneeded: Covered by existing tests -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1582967 Title: Comment deletion forms & buttons with non-unique IDs Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: While working on Bug 1580499, I noticed that the forms and buttons for comment deletion all have the same ID. This specifically gets in the way of me using their IDs for some workarounds in the Behat tests, but also it's just bad HTML. According to the HTML spec, the "ID" attribute is meant to be unique in the whole page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1582967/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
