Reviewed: https://reviews.mahara.org/6575 Committed: https://git.mahara.org/mahara/mahara/commit/7f697c51b48d3177ad239a18d1826235a27eda60 Submitter: Robert Lyon ([email protected]) Branch: 16.04_STABLE
commit 7f697c51b48d3177ad239a18d1826235a27eda60 Author: Aaron Wells <[email protected]> Date: Wed Jun 8 19:09:58 2016 +1200 Bug 1588613: Later session start so we can use DB config table The session init code relies on $CFG->session_timeout, which is normally defined in the config table. So, we need to start the session after opening the database connection. (In the event that there's an earlier session start, for instance due to an error message, this will cause the session for that page load to disregard any database config values. But that's not a show-stopper, and there's no easy way to fix it.) Change-Id: Iffbeebc8e92929970a558ff0fbc726719bb92741 behatnotneeded: Covered by existing tests (cherry picked from commit 12cb73cf14e7cd0fb5e4b03615e0dfb501bf86c3) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1588613 Title: Mahara not respecting session lifetime setting from admin config page Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: It seems that after the last round of session fixing bugs, Mahara no longer respects the session lifetime setting that the admin can set on the site configuration page. This setting is stored in the database config table as "session_timeout". It's then retrieved from the database during session setup, and loaded into the "session.gc_maxlifetime" ini value. The problem is, we are now initiating the session *before* we launch the database connection. So when we are setting session.gc_maxlifetime, session_timeout isn't available, and instead we use the default value of 1440 seconds = 24 minutes. The quick workaround is to add your session_timeout setting to your config.php: $cfg->session_timeout = 14400; // session timeout of 4 hours To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1588613/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
