Reviewed: https://reviews.mahara.org/6561 Committed: https://git.mahara.org/mahara/mahara/commit/0440e879a6cdf46710b73da2d5a70f64508e12ca Submitter: Son Nguyen ([email protected]) Branch: 15.10_STABLE
commit 0440e879a6cdf46710b73da2d5a70f64508e12ca Author: Robert Lyon <[email protected]> Date: Tue Jun 7 09:49:22 2016 +1200 Bug 1563143: Avoid displaying the dropzone image preview block This was the existing 1504 functionality behatnotneeded Change-Id: I9cf3ab67347c39ab22587fcb57d354fa44299bbe Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1563143 Title: Breakage around dropzone error hander callbacks Status in Mahara: In Progress Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Triaged Status in Mahara 16.10 series: Triaged Bug description: Catalyst received a bug report from a customer who is using recent Mahara (15.10.1). The initial bug report is that if "Require agreement" is enabled in admin/extensions/pluginconfig.php?plugintype=artefact&pluginname=file&type=file and a user attempts to upload a file without first ticking the agreement box, they get a message saying the box needs to be ticked but the preview of the file also has a green tick (implying it was actually uploaded). In my investigation of the issue, I found multiple issues: 1) Dropzone's internal handling puts the green tick there on the basis of the server status. Setting the http response code to 403 (Forbidden) fixed that. 2) Dropzone's internal handling assumes that any text returned when an error occurs is an HTML (not JSON) description of the error, and therefore puts the raw HTML in 'tooltip' for the red X. The raw HTML also ends up being displayed in the files_filebrowser_upload_messages div because the JSON.parse doesn't get called in the error handler function. I have prepared a patch that addresses both these issues, but I don't think it's the entire solution. I'd also suggest that beginning the upload should be rejected if the box hasn't been ticked. This would avoid the scenario wherein a user attempts to upload a large file on a slow connection, only to be told after the file has been sent that it's not been saved only because they didn't tick the box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1563143/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
