I've been testing out this series of patches. Everything looks pretty good so far. I think one item we've discussed is that there's a little bumpiness in the upgrade. In order for a site that's using SAML to upgrade they have to:
1. Run "make ssphp" to download simplesamlphp and its dependencies via composer (although I guess the plan is to include these in the build ZIPs). 2. Copy the Identity Provider(s) metadata files from the old outside-of- mahara simplesaml code directory, and paste them as XML into the IdP field of the relevant SAML auth instances in Mahara. Currently there's no warning or anything when you upgrade, telling you this. Since we didn't bump the version number of the plugin, there's actually no indication at all that anything has changed, until you try to log in via SAML and it doesn't work. So I think it'd be good if we did this: 1. Bump the plugin's version number so it shows up as an upgrade (even though we're not making any database changes) 2. Put some code in there that at least prints a warning message if you're trying to upgrade and you haven't got the SimpleSAMLphp code downloaded via composer. 3. I think it may also be possible to get the old IdP metadata from the old simplesaml location and enter it into the relevant auth instances. I'm fairly certain SimpleSAMLphp has a function that will let you list the registered IdP's, and to convert it from PHP format to XML if needed. We could just access the old SimpleSAMLphp code location (since we haven't deleted the configuration that indicates where its paths are located), get the data from there, and insert it into the relevant auth instances. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1579285 Title: Add SimpleSAMLphp as a managed dependency Status in Mahara: In Progress Bug description: Add SimpleSAMLphp as a managed dependency of auth/saml using make to pull to auth/saml/extlib To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1579285/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
