Reviewed: https://reviews.mahara.org/6629 Committed: https://git.mahara.org/mahara/mahara/commit/0b5a06064f42207f903abe411cd0710fbb31b0e8 Submitter: Robert Lyon ([email protected]) Branch: 16.04_STABLE
commit 0b5a06064f42207f903abe411cd0710fbb31b0e8 Author: Aaron Wells <[email protected]> Date: Fri Jun 24 15:15:48 2016 +1200 Bug 1595789: Make NULL urlsecret work during installation It was failing because we'd set the default value on param_alphanumext() to "null". But if the default passed to that function evaluates to false (as null does), then the function acts as if you've passed no default, and hence it's a required function. Further, the template form where we add the urlsecret to the install button, in case of a null urlsecret, would wind up adding "urlsecret=" to the end of the URL. param_alphanumext() would see the presence of the "urlsecret" query parameter, so it would evaluate this to match its regex, which requires there to be at least one character in the value. And then that would throw a "ParameterException" when the check failed. Change-Id: I1fb4ed7bcfe14155532e4ebb5d8c0dbdc33d1d36 behatnotneeded: Can't yet test in behat (cherry picked from commit a334a69e96810dee124bb8a2a19746a59f3cf3a2) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1595789 Title: "$cfg->urlsecret = null;" doesn't work during installation Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: According to config-defaults.php, if you set $CFG->urlsecret to null, you should be able to access the installer and upgrader without needing to add a urlsecret param to your URL. This is a useful feature for development environments. However, it currently doesn't work on the latest HEAD in master. To replicate: 1. Add "$cfg->urlsecret = null;" to your config.php file 2. Try to do a new install of Mahara through the web browser Expected result: Installation runs through Actual result: You get this message: Mahara: Invalid Parameter A required parameter is missing or malformed The 'urlsecret' parameter contains invalid characters To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1595789/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
