Reviewed: https://reviews.mahara.org/6659 Committed: https://git.mahara.org/mahara/mahara/commit/d6afb35ee970a4db29920e0670360ef4c6e1f946 Submitter: Robert Lyon ([email protected]) Branch: master
commit d6afb35ee970a4db29920e0670360ef4c6e1f946 Author: Aaron Wells <[email protected]> Date: Wed Jul 6 18:54:49 2016 +1200 Bug 1599373: Don't print the "share page" or "display page" links for site pages Since we now have multiple places that check whether the view is a site template page, I've consolidated the logic for it into View::is_site_template() Change-Id: Ibf23fe14d7f5bba8e1dc5a1281a2534d32b9887a behatnotneeded: Test to be provided later -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1599373 Title: Don't print "share page" link when viewing site template pages Status in Mahara: Fix Committed Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: Fix Committed Bug description: Currently when you edit the Profile site template, or the Page site template, you confusingly see a "share page" link on them. This link shouldn't be there, because site template pages aren't meant to be shared and seen by people like normal pages. They're only there to define the default blocks that are present in new pages of their pagetype. To replicate: 1. Log in to Mahara 2. Go to Administration -> Configure site -> Pages 3. Click the edit link for "Page template" Expected result: You see the page template in edit mode, but with no "Share page" link Actual result: You see the page template in edit mode, *with* a "Share page" link The same happens for the Profile template. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1599373/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
