Reviewed: https://reviews.mahara.org/6744 Committed: https://git.mahara.org/mahara/mahara/commit/b469030b12e80147d406fc00b75afe024a329402 Submitter: Robert Lyon ([email protected]) Branch: master
commit b469030b12e80147d406fc00b75afe024a329402 Author: Aaron Wells <[email protected]> Date: Mon Jul 25 10:56:35 2016 +1200 Bug 1605127: Method signature mismatch in Activity::update_url() The abstract Activity class defines the function update_url() with no parameters, but the two subclasses that override it define it with one parameter. This will cause problems in PHP 7. It's always called with one parameter, (even in the Activity class itself) so the best option is to add one parameter to the implementation in Activity. Change-Id: I810061ed6f8c55101327e2e907bb68ebf9870380 behatnotneeded: Covered by existing tests -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605127 Title: Mismatched function declaration, update_url() in lib/activity.php Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: Fix Committed Bug description: Branch 16.04 In lib/activity.php at approx line 710 the function update_url() is declared. It has no parameters. However, at approx line 750 it is called and a parameter ($userdata->internalid) is used. One of them must be wrong, surely? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
