Reviewed: https://reviews.mahara.org/6766 Committed: https://git.mahara.org/mahara/mahara/commit/dbaebc656a35fbed870ed5b3c9162ccb5bcb9464 Submitter: Robert Lyon ([email protected]) Branch: 15.10_STABLE
commit dbaebc656a35fbed870ed5b3c9162ccb5bcb9464 Author: Ghada El-Zoghbi <[email protected]> Date: Mon Jul 25 17:14:01 2016 +1000 Bug 1606101: usr.suspendedcusr must be non-zero It turns out a lot of existing code checks the boolean value of usr.suspendedcusr to determine if a user should be treated as suspended or not. The LDAP sync cron (and, indeed, any code suspending users via a cron task) was setting usr.suspendedcusr to 0, which is boolean false, so these users would be treated as not suspended. We are going to update all usr.suspendedcusr = 0 to a valid site admin ID. Change-Id: Iecfbfd8a4cdd98d5d07149bb40c64308262ea234 behatnotneeded: Test to come later -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606101 Title: LDAP user sync using root ID to suspend users Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Mahara: 16.04.2 DB: Postgres OS: Linux There is a bug with the LDAP sync when it is suspending users: htdocs/auth/ldap/cli/sync_users.php The user that is running the cron LDAP sync job is 'root' - has an ID of 0. Mahara updates the suspended user record with the userid that is doing the suspending (i.e. suspendedcusr = 0). When validating if a user record is suspended, we check if the suspending user id is empty. Because the suspending user ID is '0', it thinks that to the suspended user is not suspended - when they should be suspended. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606101/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
