Reviewed: https://reviews.mahara.org/6795 Committed: https://git.mahara.org/mahara/mahara/commit/be39b7a42eedd7f6c7a48b370761e1d8617e2d83 Submitter: Robert Lyon ([email protected]) Branch: 15.10_STABLE
commit be39b7a42eedd7f6c7a48b370761e1d8617e2d83 Author: Aaron Wells <[email protected]> Date: Thu Feb 11 18:34:17 2016 +1300 Bug 1605071: Display JSON-style errors for ajax blocks If an Ajax block errors out, it will looks less broken to display the JSON code there than to display error.tpl (which tries to wedge a whole copy of the Mahara header and footer and everything, into the space for a block.) It would be even better to change block.js so that it actually expects a JSON response. behatnotneeded: Can't test error state via Behat Change-Id: If5cc9ed2bbb3ce453a5cb413cbecdab0205fb3b5 (cherry picked from commit 0e7c6ff5d291ea5f8427c4380b3646be4d1b49cc) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605071 Title: Display something more error-like when an AJAX block errors out Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Spinning this bug off from Bug 1544424 (Endless JS loop if there's an uncaught exception in an ajax block) since patch https://reviews.mahara.org/6055 has taken much longer than https://reviews.mahara.org/6054 to get merged. We no longer get an endless loop when an Ajax block errors out, but it still looks pretty bad. See the attached screenshot. Because the file "blocktype.ajax.php" doesn't have the "JSON" header at its top, when it errors out, Mahara tries to print the full error page with the navigation headers and the message "Mahara: Site unavailable", and then ajaxblocks.js tries to display it in the little iframe reserved for that block. This looks confusing to the user, and it can spill over out of that block's space and cover up adjacent blocks. It would be better if we printed something that more obviously indicates that just this one block is broken, and that doesn't break the display of other blocks. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
