Reviewed: https://reviews.mahara.org/6650 Committed: https://git.mahara.org/mahara/mahara/commit/c71c5d43c964861a2a02a7be2762109994b4d0fa Submitter: Son Nguyen ([email protected]) Branch: master
commit c71c5d43c964861a2a02a7be2762109994b4d0fa Author: Ghada El-Zoghbi <[email protected]> Date: Tue Jul 5 13:49:17 2016 +1000 Bug 1598990: Verify the import format from an external source is correct. Check the format of the record in the import_queue table when processing the queue. Ensure it always defaults to a valid format that is installed and enabled. If it is not valid, throw an error. Clean up the call PluginImport::create_new_queue() by removing the non-existant 'plugin' field. Also, wrap the importer in a try/catch so the core_import_process_queue cron process can contiue if there is an error. And, validate that the keypair_PEM exists when checking openssl_open(). behatnotneeded Change-Id: Icde78f862ca0e120b67393f4a5abf464695f5104 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1598990 Title: Cannot instantiate abstract class PluginImport Status in Mahara: Fix Committed Bug description: Mahara: 16.04.1 OS: Linux DB: Postgres Browser: Firefox During the cron task run for core_import_process_queue, we are getting this error: PHP Fatal error: Cannot instantiate abstract class PluginImport in /var/www/site-anu/import/lib.php on line 191 The import_queue table has a few record with format = ''. It is trying to import leap2A data into Mahara from Moodle. The Moodle version is 2.7 which is using an older version of the submission plugin. But, that shouldn't matter. I think we need 2 things: 1) Check that the format is correct in PluginImport::class_from_format(). If it's not correct, default it to leap. 2) When the importer is created in import_process_queue(), it should be wrapped in the try/catch block. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1598990/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
