Submitter: Robert Lyon (robe...@catalyst.net.nz)
Author: Aaron Wells <aar...@catalyst.net.nz>
Date: Tue Dec 15 13:17:34 2015 +1300
Get rid of redundant DB writes in set_config()
Bug 1526073. Also in set_config_plugin() and
set_config_institution() is more complicated, and outside
the scope of this bug.
behatnotneeded: Covered by existing tests
(cherry picked from commit a79dd6bbeaee8f62ebeab6dfd697089cbfa1e1ca)
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
set_config() writes to the database even if it's not necessary
Status in Mahara:
Mahara's set_config() methods updates the database every single time
you call it, even if you haven't actually changed the value of the
It would be more efficient if it did not do this. Especially since it
already does a SELECT statement to check whether it needs to do an
UPDATE or INSERT, it would be trivial to also make it check to see if
the value in the database is the same as the value passed by the user,
and skip that UPDATE if so.
To manage notifications about this bug go to:
Mailing list: https://launchpad.net/~mahara-contributors
Post to : email@example.com
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp