As there is a fine alternative, namely CONCAT(), for both MySQL and
Postgres, which I personally find easier to understand what is going on,
we should use that.

You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or forum before editing or unsubscribing it!

  MySql concat string needs to be used instead of ||

Status in Mahara:

Bug description:
  Mahara 15.10
  OS: Ubuntu 14.04
  DB: Mysql 5.5
  Browser: any

  I've noticed that in htdocs/search/internal/lib.php, the SQL used to
  concatenate strings is '||'.

  For example, line 275:
  $sql = $alias . '.' . $field . ' ' . db_ilike() . " '%' || ? || '%'";

  Unfortunately, this doesn't always work with Mysql. In order for this to work 
we would need to set PIPES_AS_CONCAT

  Please refer to the documentation:

  Otherwise, strings need to be concatenated using: 'CONCAT'.

  This function is also available in Postgres.

  So, perhaps we should be using CONCAT instead of '||'.

  So, the above line 275 would be:
  $sql = $alias . '.' . $field . ' ' . db_ilike() . " concat('%', ? , '%')";

To manage notifications about this bug go to:

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to