Reviewed: https://reviews.mahara.org/7223 Committed: https://git.mahara.org/mahara/mahara/commit/c86ff89f45f02f973362c7df41b943b512fb29e3 Submitter: Robert Lyon ([email protected]) Branch: 16.10_STABLE
commit c86ff89f45f02f973362c7df41b943b512fb29e3 Author: Robert Lyon <[email protected]> Date: Thu Oct 27 08:42:20 2016 +1300 Bug 1636866: Allowing the empty check of get_config() option The pre php5.5 "Can't use method return value in write context" issue behatnotneeded Change-Id: Ie5f122d96eddb643b3931eac29e8367323611cf8 Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit 86a52f49c8706b7c78ebcdccb3a0d3661e4a99c9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1636866 Title: auth/saml/lib.php breaks PHP 5.4 compatability Status in Mahara: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: Hi, I'm installing Mahara 16.10.0 on a server running PHP 5.4.45. Line 453 of auth/saml/lib.php breaks compatibility with PHP 5.4 if (empty(get_config('memcacheservers')) && !extension_loaded('memcache')) { Prior to 5.5 this should be something like $memcacheservers_config = get_config('memcacheservers'); if (empty($memcacheservers_config) && !extension_loaded('memcache')) {...} Either auth/saml/lib.php needs changed or the README.md needs updated to reflect that the required minimum version is now 5.5. I only spotted this as my development server still runs 5.4, mu live server is on 5.6. Kevin To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1636866/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
