Reviewed: https://reviews.mahara.org/7266 Committed: https://git.mahara.org/mahara/mahara/commit/d72c56b5298ffaa2c77a026e906eb8b9858d8b64 Submitter: Robert Lyon ([email protected]) Branch: master
commit d72c56b5298ffaa2c77a026e906eb8b9858d8b64 Author: Cecilia Vela Gurovic <[email protected]> Date: Tue Nov 22 12:50:43 2016 +1300 Bug 1643365: Match function parameter Functions in classes and their parents should have matching paramenters. behatnotneeded Change-Id: Ib989f6c3ec5644507cccafb296cd5ae595f29d16 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1643365 Title: LeapImportArtefactPlugin warning when extending class adds parameters in method Status in Mahara: Fix Committed Bug description: When trying to import a Leap2A file, the operation in successful but shows following warning for several classes: [WAR] de (artefact/resume/import/leap/lib.php:0) Declaration of LeapImportResume::import_author_data(PluginImport $importer, $persondataid) should be compatible with LeapImportArtefactPlugin::import_author_data(PluginImportLeap $importer, $persondataid) [WAR] de (artefact/plans/import/leap/lib.php:0) Declaration of LeapImportPlans::setup_relationships(SimpleXMLElement $entry, PluginImportLeap $importer) should be compatible with LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry, PluginImportLeap $importer, $strategy, array $otherentries) [WAR] de (artefact/annotation/import/leap/lib.php:0) Declaration of LeapImportAnnotation::setup_view_relationships(SimpleXMLElement $entry, PluginImportLeap $importer) should be compatible with LeapImportArtefactPlugin::setup_view_relationships(SimpleXMLElement $entry, PluginImportLeap $importer, $strategy, array $otherentries) [WAR] de (artefact/comment/import/leap/lib.php:0) Declaration of LeapImportComment::setup_relationships(SimpleXMLElement $entry, PluginImportLeap $importer) should be compatible with LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry, PluginImportLeap $importer, $strategy, array $otherentries) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1643365/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
