Reviewed: https://reviews.mahara.org/7324 Committed: https://git.mahara.org/mahara/mahara/commit/5de73f74a826837e8772936eb88ad449f5e1103b Submitter: Ghada El-Zoghbi ([email protected]) Branch: master
commit 5de73f74a826837e8772936eb88ad449f5e1103b Author: Robert Lyon <[email protected]> Date: Mon Dec 12 16:35:09 2016 +1300 Bug 1649177: PHP7 declaration compatibility issues in internalmedia blocks behatnotneeded Change-Id: Iece5a0dc5cbdfa52bcced3923a0259834380cd31 Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1649177 Title: Declaration issuesfor PHP7 on CLI install Status in Mahara: In Progress Bug description: There are these errors on CLI install in master [WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:443) Declaration of MaharaMediaPlayer_flash::get_unique_id($artefact, $block) should be compatible with MaharaMediaPlayer::get_unique_id(ArtefactType $artefact, BlockInstance $block) Call stack (most recent first): * log_message("Declaration of MaharaMediaPlayer_flash::get_unique...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 443) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521 * error(2, "Declaration of MaharaMediaPlayer_flash::get_unique...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 443, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239 * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67 [WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:623) Declaration of MaharaMediaPlayer_html5audio::get_unique_id($artefact, $block) should be compatible with MaharaMediaPlayer::get_unique_id(ArtefactType $artefact, BlockInstance $block) Call stack (most recent first): * log_message("Declaration of MaharaMediaPlayer_html5audio::get_u...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 623) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521 * error(2, "Declaration of MaharaMediaPlayer_html5audio::get_u...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 623, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239 * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67 [WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:623) Declaration of MaharaMediaPlayer_html5audio::get_js_initjs(ArtefactTypeFile $artefact, BlockInstance $block, $width, $height) should be compatible with MaharaMediaPlayer::get_js_initjs(ArtefactType $artefact, BlockInstance $block, $width, $height) Call stack (most recent first): * log_message("Declaration of MaharaMediaPlayer_html5audio::get_j...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 623) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521 * error(2, "Declaration of MaharaMediaPlayer_html5audio::get_j...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 623, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239 * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67 [WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:680) Declaration of MaharaMediaPlayer_html5video::get_unique_id($artefact, $block) should be compatible with MaharaMediaPlayer::get_unique_id(ArtefactType $artefact, BlockInstance $block) Call stack (most recent first): * log_message("Declaration of MaharaMediaPlayer_html5video::get_u...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 680) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521 * error(2, "Declaration of MaharaMediaPlayer_html5video::get_u...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 680, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239 * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67 [WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:680) Declaration of MaharaMediaPlayer_html5video::get_js_initjs(ArtefactTypeFile $artefact, BlockInstance $block, $width, $height) should be compatible with MaharaMediaPlayer::get_js_initjs(ArtefactType $artefact, BlockInstance $block, $width, $height) Call stack (most recent first): * log_message("Declaration of MaharaMediaPlayer_html5video::get_j...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 680) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521 * error(2, "Declaration of MaharaMediaPlayer_html5video::get_j...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 680, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569 * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239 * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1649177/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
