** Changed in: mahara
Milestone: 17.04.0 => None
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1608682
Title:
Remove obsolete print_auth_frame() code
Status in Mahara:
Invalid
Bug description:
Code added in 2008 for ajaxlogin around file upload was mostly removed
in 2009 but a few remnants were left behind.
See comment in patchset #9 for https://reviews.mahara.org/#/c/5542
Regarding the comment about the deleted function 'show_login_form()'
being used in htdocs/lib/htmloutput.php
It is used because htdocs/auth/lib.php calls the php function
print_auth_frame() inside the
if (defined('IFRAME')) { }
But it doesn't look like we define IFRAME anywhere.
Ah but we used to in 2008 ->
f7fe047518b3a21b9d12323da7d5d338a33e6d8b
But got rid of the stuff relating to it in 2009 ->
fdf71aa0db535f39815a53d0677af674ce2a8d80
So this is leftover code and can be removed
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1608682/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to : [email protected]
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
