Reviewed: https://reviews.mahara.org/7782 Committed: https://git.mahara.org/mahara/mahara/commit/a4577946c3d7b8a62aafcbc3c8cf4d5f91e7cc78 Submitter: Robert Lyon ([email protected]) Branch: 16.04_STABLE
commit a4577946c3d7b8a62aafcbc3c8cf4d5f91e7cc78 Author: Robert Lyon <[email protected]> Date: Sun May 14 16:09:28 2017 +1200 Bug 1690232: Comments link on retractable block failing to open modal Actually the modal is opening and closing in the same instant. This is caused by some code dealing with collapsible blocks making sure modals are closed if outside certain rules. This change checks what modal we are wanting and closing all but the one are targeting when clicking the 'comments' link behatnotneeded Sponsored by SWITCH Change-Id: Idb5165bdc8349f77286aa776ff75d152968aefda Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit 5ce66781dfa1bd23f1bb632b9e61e68677259358) (cherry picked from commit b2858fcf96d80809b8a9d6af4a85a9fc8d7fc392) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
