Reviewed: https://reviews.mahara.org/7990 Committed: https://git.mahara.org/mahara/mahara/commit/12c0a6c681d39af1773bbbe617128c092a519793 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 17.04_STABLE
commit 12c0a6c681d39af1773bbbe617128c092a519793 Author: Robert Lyon <robe...@catalyst.net.nz> Date: Wed Sep 6 11:03:44 2017 +1200 Bug 1715260: Keep tinymce fields on block config form error behatnotneeded - will be covered by annotation_block.feature Change-Id: Ibc5652e208ff4d65d2e845678db00ce245e91f63 Signed-off-by: Robert Lyon <robe...@catalyst.net.nz> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1715260 Title: When adding blank annotation via page editor it removes tinymce from field Status in Mahara: In Progress Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: In Progress Bug description: Because the form is added again via viewmanager it doesn't have the tinymce started in it on form error return. I'll add the code to rewire them back up. ---------- To test: 1) Enable annotation block via Admin -> Extensions 2) Create a page and add annotation block to it 3) Don't fill in anything in annotation field but hit 'save' You should see the error 'This field is required.' Before patch the field stops being a TinyMCe field and becomes a normal one After patch (and hard refresh of javascript on page edit screen) You should see the error 'This field is required.' and the field stay a tinyMCE field To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1715260/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp